[Spark] Replaces startTransaction(Snapshot) calls with catalogTable overload #2126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasRupprecht
changed the title
| @@ -612,7 +612,7 @@ case class CreateDeltaTableCommand( | |||
| deltaLog: DeltaLog, | |||
| tableWithLocation: CatalogTable, | |||
| snapshotOpt: Option[Snapshot] = None): OptimisticTransaction = { | |||
| val txn = deltaLog.startTransaction(snapshotOpt) | |||
| val txn = deltaLog.startTransaction(None, snapshotOpt) | |||
There was a problem hiding this comment.
This could use a comment why we don't pass tableWithLocation. I believe the reason is, tableWithLocation is the proposed catalog table entry, which will be installed by this command but does not yet exist as-of the start of the transaction?
scottsand-db
pushed a commit
that referenced
this pull request
Oct 6, 2023
…verload This PR replaces all calls to DeltaLog.startTransaction(Snapshot) with calls to DeltaLog.startTransaction(Option[CatalogTable], Snapshot). This PR is part of #2105 and a follow-up to #2125. It makes sure that transactions have a valid catalogTable attached to them so Uniform can correctly update the table in the catalog. This is a small refactoring change so existing test coverage is sufficient. No Closes #2126 GitOrigin-RevId: d82787c64979a2dd4a363bf92a1640b7635ec02e
xupefei
pushed a commit
to xupefei/delta
that referenced
this pull request
Oct 31, 2023
…verload This PR replaces all calls to DeltaLog.startTransaction(Snapshot) with calls to DeltaLog.startTransaction(Option[CatalogTable], Snapshot). This PR is part of delta-io#2105 and a follow-up to delta-io#2125. It makes sure that transactions have a valid catalogTable attached to them so Uniform can correctly update the table in the catalog. This is a small refactoring change so existing test coverage is sufficient. No Closes delta-io#2126 GitOrigin-RevId: d82787c64979a2dd4a363bf92a1640b7635ec02e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This PR replaces all calls to DeltaLog.startTransaction(Snapshot) with calls to DeltaLog.startTransaction(Option[CatalogTable], Snapshot). This PR is part of #2105 and a follow-up to #2125. It makes sure that transactions have a valid catalogTable attached to them so Uniform can correctly update the table in the catalog.
How was this patch tested?
This is a small refactoring change so existing test coverage is sufficient.
Does this PR introduce any user-facing changes?
No