[Spark] In materialize merge source: Only log storage error if we actually materialized #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliuszsompolski
approved these changes
Mar 7, 2024
5 tasks
tdas
pushed a commit
that referenced
this pull request
Mar 8, 2024
#### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [ ] Flink - [ ] Kernel - [X] Other (fill in here) ## Description This removes compiling unidoc from the spark CI tests since we've seen a flaky failure on #2727. We will follow up and create a separate job just for unidoc (which makes more sense anyways as it should run for changes in any of the projects.) ## How was this patch tested? CI runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Be more defensive about calling
Option.getonmaterializedSourceRDDand check first that it's actuallySome. In fact only invoke the entire branch where we log only when we actually did materialize the source (and not, say, ran out of disk space before).How was this patch tested?
This PR adds a new test for the scenario where we throw an out of disk space error without having materialized the source.
Does this PR introduce any user-facing changes?
No