[Spark][Test-Only] Add Row Tracking Clone tests with empty source table #2742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longvu-db
commented
Mar 11, 2024
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdCloneSuite.scala
Outdated
Show resolved
Hide resolved
longvu-db
force-pushed
the
oss-row-id-clone-empty-source
branch
2 times, most recently
from
eaa0ebe to
185c7a3
Compare
fred-db
reviewed
Mar 15, 2024
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdCloneSuite.scala
Outdated
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdCloneSuite.scala
Outdated
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/rowid/RowIdCloneSuite.scala
Outdated
Show resolved
Hide resolved
longvu-db
force-pushed
the
oss-row-id-clone-empty-source
branch
from
185c7a3 to
4d49d02
Compare
longvu-db
force-pushed
the
oss-row-id-clone-empty-source
branch
from
4d49d02 to
06606e0
Compare
johanl-db
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Add Materialized Row Tracking columns CLONE tests, making sure we have enough Row Tracking test coverage necessary to gear us towards enabling Row Tracking outside of testing.
How was this patch tested?
Existing + added UTs.
Does this PR introduce any user-facing changes?
No.