Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History truncation/validation support for writer features in DROP FEATURE command #3296

Merged

Conversation

andreaschat-db
Copy link
Contributor

@andreaschat-db andreaschat-db commented Jun 24, 2024

Which Delta project/connector is this regarding?

  • Spark
  • Standalone
  • Flink
  • Kernel
  • Other (fill in here)

Description

Currently, history truncation/validation in DROP feature command is only performed for reader+writer features. This PR enables this functionality for writer features as well. For reader+writer features is always is enabled by default while for writer features it was to be explicitly enabled.

How was this patch tested?

Added new tests in DeltaProtocolVersionSuite.

Does this PR introduce any user-facing changes?

No.

Copy link
Contributor

@larsk-db larsk-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xupefei xupefei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@scottsand-db scottsand-db merged commit eb26989 into delta-io:master Jun 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants