[Spark] Fix NoSuchElementException in DeltaHistoryManager parallel search with empty commits #3972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -211,6 +211,9 @@ class DeltaHistoryManager( | |||
| start, | |||
| Some(end), | |||
| deltaLog.newDeltaHadoopConf()) | |||
| if (commits.isEmpty) { | |||
| throw DeltaErrors.noHistoryFound(deltaLog.logPath) | |||
There was a problem hiding this comment.
Is this the right exception to throw here when [start, end) don't cover the entire history? All the other changes look good though.
sumeet-db
force-pushed
the
fix_time_travel_exception
branch
from
17b686d to
e56a4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
When performing time travel operations that trigger parallel search in DeltaHistoryManager (when searching through >2000 commits), a NoSuchElementException can occur if some partitions return empty commit lists. This happens because the code attempts to call .head on potentially empty collections without proper checks.
How was this patch tested?
UTs
Does this PR introduce any user-facing changes?
No