[PROTOTYPE] [EARLY FEEDBACK REQUESTED] Kernel accept opaque committer properties; UC committer extensibility #5230
+133
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottsand-db
changed the title
scottsand-db
commented
Sep 18, 2025
| * <p>This method allows subclasses to provide custom committer implementations for specialized | ||
| * use cases. | ||
| */ | ||
| protected Committer createUCCommitter(UCClient ucClient, String ucTableId, String tablePath) { |
Collaborator
Author
There was a problem hiding this comment.
Code smell here. I wonder if we should abandon the UCCatalogManagedClient::loadSnapshot API -- and instead just provide static utilities (like getting the commits, parsing the commits, etc.)
scottsand-db
commented
Sep 18, 2025
| * Adds custom properties that will be passed through to the committer. These properties allow | ||
| * connectors to inject catalog-specific metadata without Kernel inspection. | ||
| */ | ||
| void withCommitterProperties(Supplier<Map<String, String>> committerProperties); |
Collaborator
Author
There was a problem hiding this comment.
Added here instead of on the builder so Connectors can inject any properies they'd like at any point.
e.g. maybe these properties depend on the data files written
scottsand-db
commented
Sep 18, 2025
| TransactionCommitResult commit(Engine engine, CloseableIterable<Row> dataActions) | ||
| throws ConcurrentWriteException; | ||
|
|
||
| /** |
Collaborator
Author
There was a problem hiding this comment.
I don't love how this is on the Txn and not the TxnBuilder ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?