[Delta Spark] always check iceberg MOR during clone #5267
+16
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
always check iceberg MOR during clone; The existing impl had day 0 problem that it miss to check iceberg MOR during incremental conversion, and thus its possible that the table has MOR with format-version 2. If the check is missed, the converted table state will be wrong and result in data corruption. This bug is not reported by customer and is found during internal code review.
Note we explicitly document we do not support iceberg format-version2 MOR; This fix hardens the detection.
This change also fixes an issue where it checks deleteManifests, which could contain removed DeleteFiles after the table is compacted. Using total-delete-files in summary is the right detection for if delete files are present.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?