organize remotely executing functions in "cmdeploy.remote" sub package #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpk42
force-pushed
the
hpk/sshexec-pkg
branch
3 times, most recently
from
ba33968 to
04fe7d5
Compare
link2xt
reviewed
Aug 9, 2024
| @@ -0,0 +1,17 @@ | |||
| from subprocess import CalledProcessError as ShellError | |||
There was a problem hiding this comment.
because the module is about running shell commands, and it's not neccessary to leak that it's subprocess.CalledProcessError ... maybe not neccessary but also not hurting i'd say.
There was a problem hiding this comment.
I guess this does not change the repr of the exception if it gets into some stacktrace?
Would prefer not renaming imported functions and classes, this just makes it hard to find them in the documentation and any stacktraces will point to the real name anyway.
link2xt
approved these changes
Aug 15, 2024
link2xt
approved these changes
Sep 2, 2024
hpk42
force-pushed
the
hpk/sshexec-pkg
branch
from
b55dc2b to
8ea0f6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR does not change any business logic but re-organizes "sshexec" calls to remote functions
such that the 'cmdeploy.remote' package is transferred to the remote side and one can
now specify any function relative to the remote sub package, and not just a single module.
This allows to write more code in modules and not having to lump everything into a single
remote_funcs.pymodule.It also allows all modules in that sub package to import each other.