Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove old emojis #3411

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

remove old emojis #3411

wants to merge 8 commits into from

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Nov 4, 2024

use modern emoji2-emojipicker instead

close #3399

To Do:

  • remove old emoji images assets
  • remove "use system emojis" preference
  • use emoji2-emojipicker instead of old emoji picker
  • implement on-click event in new emoji picker
  • fix emoji text views
  • delete old emoji code
  • fix emoji color for reaction pills
  • enlarge font size when text is only a few emojis

image

@adbenitez adbenitez self-assigned this Nov 4, 2024
Copy link

github-actions bot commented Nov 4, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez added bug enhancement actually in development, user visible enhancement labels Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

github-actions bot commented Nov 5, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez marked this pull request as ready for review November 5, 2024 22:08
@adbenitez adbenitez requested review from r10s and Hocuri November 5, 2024 22:08
Copy link

github-actions bot commented Nov 5, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez
Copy link
Member Author

caveats:

  • after a lot of searching for solutions I didn't find any proper&easy way to detect emojis in text in java for the font size scaling effect, so if you send a single emoji the message will look the same as any other message, hopefully core could help with this in the future
  • the emoji picker doesn't have a delete button, this could be added eventually when we add a row to switch between emojis and sticker picker, that is how it is in whatsapp

Copy link

github-actions bot commented Nov 6, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement actually in development, user visible enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problems with reactions and old built-in emojis
2 participants