UITests #2372
Draft
UITests #2372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amzd
commented
Nov 2, 2024
Comment on lines
+64
to
+71
| if CommandLine.arguments.contains("--UITests") { | ||
| // TODO: FIX | ||
| // FIXME: I think this is a bug but sendMessage does not publish the DC_EVENT_MSGS_CHANGED event in UITests. Probably because the message is not actually sent due to it not being a real, functioning account? | ||
| NotificationCenter.default.post(name: Event.messagesChanged, object: nil, userInfo: [ | ||
| "message_id": message.id, | ||
| "chat_id": chatId, | ||
| ]) | ||
| } |
There was a problem hiding this comment.
Not sure where to report this but I think this is a bug in core but not one that would affect any real users, just UITests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a UITest for the chat view controller. There is a couple TODO comments that can maybe be fixed but I don't think they are blocking.
I don't know how to handle xcproj changes, they are a mystery to me.