Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I was too impatient for Un'Goro in Metastone, so i made this... #348

Open
Muhframos opened this issue May 18, 2017 · 28 comments
Open

I was too impatient for Un'Goro in Metastone, so i made this... #348

Muhframos opened this issue May 18, 2017 · 28 comments

Comments

@Muhframos
Copy link

Muhframos commented May 18, 2017

Unpatient with the coming of Metastone 1.40, i decided to create as many Un'Goro cards as i could...
Unfortunately, Quests, Permanents, Elemental synergy and some other cards was something i couldnt do, so this might not help the developers much.

Sealed Un'Goro Pack.zip

But hey, at least i tried lmao.

On a side note, i noticed i must've done something wrong with Tortollan Forager, because it sometimes gives you Weapons with 5 or more attack. EDIT: I fixed it! Yay!

And, uh, all the cards are indicated as on the "CUSTOM" set so, thats something to keep on mind.
Inside the .ZIP there are also some folders with the Elementals from other card sets, and i also added the Elemental tag to the cards with that.

Oh, on another side note, i couldnt totally code:
Swamp King Dred (Deals damage to anything the opponent summon equal to his attack, and then deals damage to self equal to the summoned minion's attack, not dying to Poisonous minions)

Thanks for Muppet1 for the Adapt stuff.

@Muhframos Muhframos changed the title I was too unpatient for Un'Goro Metastone, so i made this... I was too impatient for Un'Goro Metastone, so i made this... May 18, 2017
@Muhframos Muhframos changed the title I was too impatient for Un'Goro Metastone, so i made this... I was too impatient for Un'Goro in Metastone, so i made this... May 18, 2017
@DominusMaximus
Copy link

On a side note, i noticed i must've done something wrong with Tortollan Forager, because it sometimes gives you Weapons with 5 or more attack.

Have you tried using the AttributeFilter class? If not, check out Shadow Word: Death as a reference.

Nice job on these cards.

@Muhframos
Copy link
Author

Muhframos commented May 18, 2017

Have you tried using the AttributeFilter class? If not, check out Shadow Word: Death as a reference.

I have used the AttributeFilter, yes, it gives me stuff with +5 attack only, the problem is that it sometimes gives me weapons, so, eh.

@DominusMaximus
Copy link

I have used the AttributeFilter, yes, it gives me stuff with +5 attack only, the problem is that it sometimes gives me weapons, so, eh.

Oh you tested both? Cause the json is using the CardFilter class.

@webadict
Copy link
Collaborator

You want CardFilter, but you need to add type: "MINION" to it. Sorry I've been slacking on updating.

@Muhframos
Copy link
Author

Muhframos commented May 18, 2017

You want CardFilter, but you need to add type: "MINION" to it

Hmmm, just "type": instead of "cardType" ? EDIT: Oh, i noticed i just was testing with the outdated version of the card, it has been fixed already. Whoopsie.

Sorry I've been slacking on updating.

No problem, this actually helped me quite a bit at coding custom cards for my friends.

@webadict
Copy link
Collaborator

Might be cardType. It's been a while

@unobserver-effect
Copy link

OMG thank you for those cards!!! I am also pretty impatient for 4.0 but I suck at coding! I am trying to learn though.

@Muhframos
Copy link
Author

Whoopsie daisy, Volatile Elemental was wrongly coded!
MISTAKE!!!
It targets enemy characters instead of enemy minions
whoops.

@Muppet1
Copy link

Muppet1 commented May 21, 2017

thanks fo
spell_hallucination

r cards. Here is a working hallucination. You need to change the extension back to json.

OOPs sorry misread the card you need to remove the line 18 which says spell or you only get spells :-).

@Muhframos
Copy link
Author

Muhframos commented May 23, 2017

oh whoopsies, Hallucination is just named Journey Below, lmao >_>
does it not work tho? (my version o' it)

@Muppet1
Copy link

Muppet1 commented May 28, 2017

here is Tarcreeper
minion_tar_creeper
as before rename to .json

Your Hallucination only does minions.
I am vaguely working on adapt next.

@Muhframos
Copy link
Author

Eh, i should've checked these cards better before posting them
hmmm... one more thing, the voraxx is buggy with some spells the way i made him so
if you're able to fix it too, it'd be nice. lul

@Muppet1
Copy link

Muppet1 commented Jun 1, 2017

here is
spell_earthen_scales
earthen scales

@Muhframos
Copy link
Author

hmmm how do i save these 🤔

@Muppet1
Copy link

Muppet1 commented Jun 2, 2017

does right click save as not work ? You then need to change the extension to json.

@Muhframos
Copy link
Author

Muhframos commented Jun 4, 2017

ah, thanks.
Hmmm... tar creeper is just a 3 mana 3/5... hm...

How about this:
minion_tar_creeper

Yay Tar minions (Tar Lord, Tar Creeper, Tar Lurker) are now functional!

@Muppet1
Copy link

Muppet1 commented Jun 5, 2017

oh sorry did I give the wrong tar creeper. and I have gentle megasaur.
minion_tar_creeper
minion_gentle_megasaur
The other adapt things shd be easy from that I hope.

@Muhframos
Copy link
Author

Muhframos commented Jun 5, 2017

Oooh, many thanks.
Just one thing, your version has permanent stealth at the moment, just add the revertTrigger thingy from Conceal and you're good.

Also, lmao, right after you posted the wrong tar creeper i coded the new version myself
nice

@Muhframos
Copy link
Author

Here you go...
Sealed Un'Goro Pack.zip

Now it has updated cards! Yay!

@Muppet1
Copy link

Muppet1 commented Jun 9, 2017

here is living m
spell_living_mana
ana I hope.
token_minion

That's about as far as I can go I can't see how to do quests or elementals that are triggered by elementals.

Hopefully the competent people will reappear soon.

@Muhframos
Copy link
Author

Hmmm
There still are some cards i couldnt code like Tortollan Primalist, Clutchmother Zavas, Elise, Primalfin Champion, Explore Un'Goro, Mana Bind, Envenom Weapon, The Voraxx (He is in the file but he is buggy with a lot of spells), Obsidian Shard (Also in the file but i couldnt code it correctly, or at least didnt try enough), Hemet Jungle Hunter, and Cruel Dinomancer.

Also, yeah, i hope the devs gib us this stuff soon, this expansion opened a lot of stuff for coding cards into Metastone, like Glimmerroot, Elise, Primalist, Envenom Weapon, Dinomancer, those cards add up a lot of possibilities.

@Muppet1
Copy link

Muppet1 commented Jul 5, 2017

check out hearthmatic if you haven't seen it.

@doctorpangloss
Copy link
Contributor

This is great. I'm going to be occasionally post issues as I find them.

Molten Reflection should have "targetSelection": "FRIENDLY_MINIONS", right now a hero can be chosen as a target which breaks.

@doctorpangloss
Copy link
Contributor

Giant Anaconda needs to have "cardType": "MINION" added to its CardFilter because otherwise it may try to summon a weapon with more than 5 attack from your hand.

@doctorpangloss
Copy link
Contributor

doctorpangloss commented Jul 6, 2017

Molten Blade and Shifter Zerus have a glitch where the ShifterZerusSpell::onCast and GameLogic::replaceCard both add the passive spelltrigger to the new card, except one does it before the game ID is assigned and the other does it after the game ID is assigned. This will cause two copies of the spell trigger to fire (then four, then eight, etc...) just eating up a lot of memory but not actually causing an exception.

Otherwise, I didn't encounter anything that breaks mass random play on the order of millions of plays.

@Muhframos
Copy link
Author

I didnt change the annaconda thingy because since this was made in a while there still was a Annaconda bug that could pull weapons out, but i guess i should change it now.

@webadict
Copy link
Collaborator

You guys did pretty well. Maybe I'll take some time to do some updates. I have just been fairly busy recently.

@guyde2011
Copy link

guyde2011 commented Jul 29, 2017

I was working on a similar collection pre-ungoro as well, here are a few that you didn't have there - Living Mana & Clutchmother Zavas (Please note that I modified the sim code as well, so the set name in the json files is JOURNEY_TO_UNGORO, but those two should work without any more modifications):

ungoro.zip

I also have some of the quests (Warlock, Druid, Hunter, Warrior, Priest and Shaman) working on my modified version as well as the elemental conditions; if anyone is interested I can send my own patches for the elementals, as they require much less changes than the quest patches.

Just a note: the [b] in the description is for my version which allows bold text on cards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants