add encode to filter arg to qradar-domain-list (#38242)

* added integration for symnatec email security (#36804) * added integration for symnatec email security * added command examples * updated according to pre-commit * updated according to pre-commit * add pre-commit error * fixed bug in error message * updated enum fields in json conversion * added readme * added type annoation and docstring * type annotations * added usecases * updated annotations * fixed pack pathing * updated pre-commit errors * updated according to pre-commit * formatted files * fixed pre commit error * Handled PR comments * Apply suggestions from code review Co-authored-by: ShirleyDenkberg <[email protected]> * added pack readme * updated docker image * updated readme * changed to datetime.UTC as of python3.11 * update docker image * update docker image * updated condition * removed whitelines * added aliases to incident fields as described in pr * updated q to query as requested --------- Co-authored-by: ShirleyDenkberg <[email protected]> * RN * from version * skip integration * skip integration * fix encoding bug --------- Co-authored-by: LiorQM <[email protected]> Co-authored-by: ShirleyDenkberg <[email protected]> Co-authored-by: Shelly Tzohar <[email protected]>
demisto · Jan 29, 2025 · 7e72762 · 7e72762
1 parent 9a155f1
commit 7e72762
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/Packs/QRadar/Integrations/QRadar_v3/QRadar_v3.py b/Packs/QRadar/Integrations/QRadar_v3/QRadar_v3.py
@@ -726,8 +726,10 @@ def reference_set_value_delete(self, ref_name: str, value: str):
 
     def domains_list(self, domain_id: Optional[int] = None, range_: Optional[str] = None, filter_: Optional[str] = None,
                      fields: Optional[str] = None):
+
         id_suffix = f'/{domain_id}' if domain_id else ''
-        params = assign_params(fields=fields) if domain_id else assign_params(filter=filter_, fields=fields)
+        encoded_filter = parse.quote(filter_, safe="") if filter_ else None
+        params = assign_params(fields=fields) if domain_id else assign_params(filter=encoded_filter, fields=fields)
         additional_headers = {'Range': range_} if not domain_id and range_ else None
         return self.http_request(
             method='GET',

diff --git a/Packs/QRadar/ReleaseNotes/2_5_10.md b/Packs/QRadar/ReleaseNotes/2_5_10.md
@@ -0,0 +1,6 @@
+
+#### Integrations
+
+##### IBM QRadar v3
+
+- Fixed an issue where **qradar-domains-list** command did not perform encoding for the filter argument.
diff --git a/Packs/QRadar/pack_metadata.json b/Packs/QRadar/pack_metadata.json
@@ -2,7 +2,7 @@
     "name": "IBM QRadar",
     "description": "Fetch offenses as incidents and search QRadar",
     "support": "xsoar",
-    "currentVersion": "2.5.9",
+    "currentVersion": "2.5.10",
     "author": "Cortex XSOAR",
     "url": "https://www.paloaltonetworks.com/cortex",
     "email": "",