Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreatVault EDL Feed #37465

Merged
merged 17 commits into from
Dec 30, 2024
Merged

ThreatVault EDL Feed #37465

merged 17 commits into from
Dec 30, 2024

Conversation

Ni-Knight
Copy link
Contributor

@Ni-Knight Ni-Knight commented Nov 28, 2024 •
edited
Loading

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

related: https://jira-dc.paloaltonetworks.com/browse/CIAC-10961

Description

This is a feed based on PANW ThreatVault EDLs

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/FeedThreatVault/Integrations/FeedThreatVault
   FeedThreatVault.py1191984%153–155, 199, 245–247, 270, 305, 324–325, 328, 336–338, 340, 351–353
TOTAL1191984% 

Tests Skipped Failures Errors Time
28 0 💤 0 ❌ 0 🔥 9.045s ⏱️

@Ni-Knight Ni-Knight requested a review from samuelFain November 28, 2024 15:02
samuelFain
samuelFain requested changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please see my comments.

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Ni-Knight Ni-Knight requested a review from samuelFain December 3, 2024 15:25
ShirleyDenkberg
ShirleyDenkberg reviewed Dec 4, 2024
View reviewed changes
@ShirleyDenkberg
Copy link
Contributor

@samuelFain Doc review completed.

samuelFain
samuelFain approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Ni-Knight Ni-Knight merged commit cd69445 into master Dec 30, 2024
17 checks passed
@Ni-Knight Ni-Knight deleted the dra-feed-threatvault branch December 30, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@samuelFain samuelFain samuelFain approved these changes

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ni-Knight @CLAassistant @ShirleyDenkberg @samuelFain