ThreatVault EDL Feed #37465
Open
ThreatVault EDL Feed #37465
+879
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelFain
requested changes
Dec 2, 2024
Comment on lines
+90
to
+106
| - display: "" | ||
| name: feedExpirationPolicy | ||
| defaultvalue: indicatorType | ||
| type: 17 | ||
| required: false | ||
| options: | ||
| - never | ||
| - interval | ||
| - indicatorType | ||
| - suddenDeath | ||
| section: Collect | ||
| - display: '' | ||
| name: feedExpirationInterval | ||
| defaultvalue: '20160' | ||
| type: 1 | ||
| required: false | ||
| section: Collect |
There was a problem hiding this comment.
Are we okay with empty display: "" key for feedExpirationInterval and feedExpirationPolicy parameters?
|
|
||
| except Exception: | ||
| demisto.error(traceback.format_exc()) # print the traceback | ||
| return_error(f"Failed to execute {command} command. The command not implemented") |
There was a problem hiding this comment.
Please note that any exception raised from the code would be excepted here and printed with the "The command not implemented" suffix - which may not always be suitable.
| ) | ||
|
|
||
| else: | ||
| raise DemistoException(f"couldn't fetch, {response.get('success')}, response.get('message')") |
There was a problem hiding this comment.
If we got to this section in the code, than response.get('success') is None, so what value does it add to print it?
Maybe we could print the error code or error message instead?
| offset += LIMIT | ||
|
|
||
| else: | ||
| raise DemistoException(f"couldn't fetch, {response.get('success')}, response.get('message')") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Related Issues
related: https://jira-dc.paloaltonetworks.com/browse/CIAC-10961
Description
This is a feed based on PANW ThreatVault EDLs