-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archer V2 search records and fetch incidents raw XML filtering #37615
base: master
Are you sure you want to change the base?
Conversation
@dorschw Doc review completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall, check my comments.
@@ -997,6 +1006,7 @@ Search for records inside the given application | |||
| fullData | Whether to get extended responses with all of the data regarding this search. For example, "fullData=true" | Required | | |||
| isDescending | Whether to order by descending order. Possible values are: "true", "false". | Optional | | |||
| levelId | The Level ID to use for searching. This argument is relevant when fullData is True. If empty, the command by default takes the first level ID. | Optional | | |||
| xmlForFiltering | The raw XML filter condition. For example: "DateComparisonFilterCondition" or "TextFilterCondition" XML element. | Optional | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good place to insert something like:
"Note, using DateComparisonFilterCondition or similar time-querying conditions might conflict with fetching incidents and is not supported."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is a general command and not "fetch-incidents", I did not implement this limitation here (consistent with the requirements on Jira)
Related Issues
fixes: link to the issue
Description
xmlForFiltering
argument to the archer-search-records command to allow for the filtering of records using a raw XML condition element such as: "DateComparisonFilterCondition" or "TextFilterCondition".Note
DateComparisonFilterCondition
XML element since it would interfere with the existing fetch date filter.