Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Pack] - Internal - UVEM - Cortex VM #37799

Merged

Conversation

BigEasyJ
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

UVEM-557

Description

Please review ticket

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Xsoar Support Level Indicates that the contribution is for XSOAR supported pack labels Dec 22, 2024
@content-bot content-bot changed the base branch from master to contrib/PaloAltoNetworks_UVEM-557 December 22, 2024 12:10
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YairGlik will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @BigEasyJ, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@BigEasyJ BigEasyJ marked this pull request as draft December 22, 2024 12:12
@YairGlick
Copy link
Contributor

Hi @BigEasyJ ,

Thank you so much for your contribution! Please note that the PR is still marked as a draft. If you're ready to proceed with it, kindly change its status to open.

Let me know if you need any assistance!

@karinafishman
Copy link
Contributor

Hi, here are some comments regarding the PR:

  • I can't see the release notes added to the vulnerability management pack.
  • Images of the playbooks are missing.
  • Missing Release note for Cortex VM - ServiceNow CMDB playbook.
  • Please fix all the errors in the build.

@YairGlick YairGlick requested review from JudahSchwartz and removed request for YairGlick December 30, 2024 11:09
@JudahSchwartz JudahSchwartz removed the request for review from karinafishman January 1, 2025 12:30
@mayyagoldman mayyagoldman added Internal Internal contributions like qmasters Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge labels Jan 19, 2025
@karinafishman karinafishman removed their request for review January 19, 2025 10:51
@mayyagoldman
Copy link
Contributor

mayyagoldman commented Jan 19, 2025

Hey @BigEasyJ ,

Is the PR intentionally still in draft status?

I’ve handled the first two issues you mentioned. Regarding the release notes (RN) for a new contribution pack, this is a known issue, and there is an open development bug addressing it. This issue shouldn’t be a blocker for merging the PR, so no need to worry about it.
Let me know if you need further clarification! 😊

@mayyagoldman, can you please show us how to fix these? https://github.com/demisto/content/actions/runs/12836737677/job/35798998093?pr=37799 https://github.com/demisto/content/actions/runs/12836737676/job/35798998146?pr=37799

Also, typically you dont have a release notes for 1.0.0 so how can we fix the build errors in here? https://github.com/demisto/content/actions/runs/12837076169/job/35800010100?pr=37799

Thank you in advance

@johnnywilkes
Copy link
Contributor

@mayyagoldman, yes the PR is still in draft for us to finish our testing

@BigEasyJ BigEasyJ marked this pull request as ready for review January 27, 2025 18:59
@johnnywilkes
Copy link
Contributor

@mayyagoldman , this PR is good to go, please merge when possible.

@mayyagoldman mayyagoldman added the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 28, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/2089988

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jan 28, 2025
@mayyagoldman mayyagoldman merged commit f4ac3cd into demisto:contrib/PaloAltoNetworks_UVEM-557 Jan 28, 2025
20 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

mayyagoldman pushed a commit that referenced this pull request Jan 28, 2025
* pack init

* UVEM-755 - trigger

* adding fields

* update fields

* staging for UVEM-787

* Update from EM to VM

* Remove leftover EM playbooks

* Update RankSO Script and Release Notes

* Update Dependencies

* update playbooks

* update dependencies

* Revert "Update RankSO Script and Release Notes"

This reverts commit 34850eb.

* Revert pack metadata

* description wording change

* itemPrefix

* add README

* updated to playbooks and screenshots

* fix val error

* re-add field

* Apply suggestions from code review



* fix val error

* fix input ref

* fix and change to issues

* removed end field

---------

Co-authored-by: John <[email protected]>
Co-authored-by: jwilkes <[email protected]>
Co-authored-by: johnnywilkes <[email protected]>
Co-authored-by: ShirleyDenkberg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Internal Internal contributions like qmasters pending-contributor The PR is pending the response of its creator Security Approved If a contribution has been approved for merge by the security team, then this will allow a merge Security Review Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants