Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serviceNow fix create-co-from-template #38189

Merged
merged 12 commits into from
Jan 29, 2025

Conversation

YairGlick
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

Copy link

github-actions bot commented Jan 16, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/ServiceNow/Integrations/ServiceNowv2
   ServiceNowv2.py144926082%178, 182, 190, 196, 454, 456, 460, 485, 527, 534–535, 573–574, 690–693, 695, 708, 715–724, 727, 730, 733–734, 748, 753–758, 769, 797, 823, 825, 827–828, 830–831, 833–836, 838, 884, 888, 909–911, 914–916, 919, 922, 1031, 1157–1163, 1165, 1167–1168, 1170–1173, 1175, 1177–1178, 1180, 1182–1183, 1185–1186, 1188, 1191–1192, 1194, 1206–1207, 1238, 1275, 1278, 1285, 1293, 1299, 1351, 1390, 1420, 1449–1450, 1455, 1540, 1595, 1598, 1642, 1644–1646, 1648–1649, 1682, 1685–1687, 1701, 1706–1708, 1734, 1769–1770, 1778, 1829, 1874–1877, 1879, 1882, 1889, 1935–1940, 1942–1943, 1945–1947, 1949–1950, 1952–1954, 1956–1957, 1959, 1961, 1971, 1973, 1975, 1988–1993, 1995–1996, 1998–2000, 2002–2003, 2005–2007, 2009–2010, 2012, 2021–2022, 2024, 2026, 2044, 2047, 2075, 2078, 2113, 2116, 2120, 2147, 2177, 2207, 2236, 2337, 2349, 2360, 2363, 2367–2368, 2371, 2373–2374, 2444, 2450, 2465, 2507–2508, 2546–2549, 2571–2572, 2576–2577, 2613, 2659, 2662–2664, 2677–2678, 2798, 2817, 2829, 2857, 2872, 2874, 2878–2879, 3017–3019, 3025, 3042, 3049, 3053, 3090, 3152, 3178–3179, 3184, 3199, 3244–3246, 3292, 3302, 3344–3346, 3348, 3350, 3352, 3354, 3356, 3358, 3362, 3364, 3366, 3371–3372, 3380
TOTAL144926082% 

Tests Skipped Failures Errors Time
144 0 💤 0 ❌ 0 🔥 -86666472.403s ⏱️

@YairGlick YairGlick requested a review from jbabazadeh January 21, 2025 14:57
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Please see my comments and ask for a doc-review for the RN.

@ShirleyDenkberg
Copy link
Contributor

@jbabazadeh @BEAdi Doc review completed.

@YairGlick YairGlick merged commit a687082 into master Jan 29, 2025
17 checks passed
@YairGlick YairGlick deleted the servicenow-fix-create-co-from-template branch January 29, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants