Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParseEmailFilesV2: Clarified parse_only_headers description #38255

Merged
merged 13 commits into from
Jan 28, 2025
Merged

ParseEmailFilesV2: Clarified parse_only_headers description #38255

merged 13 commits into from
Jan 28, 2025

Conversation

YairGlick
Copy link
Contributor

@YairGlick YairGlick commented Jan 21, 2025 •
edited
Loading

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-45839

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CommonScripts/Scripts/ParseEmailFilesV2
   ParseEmailFilesV2.py99891%24, 31, 90, 105–106, 108–109, 133
TOTAL99891% 

Tests Skipped Failures Errors Time
17 0 💤 0 ❌ 0 🔥 2.651s ⏱️

@YairGlick YairGlick requested a review from jbabazadeh January 22, 2025 13:23
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.13.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.14.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.15.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

BEAdi
BEAdi reviewed Jan 27, 2025
View reviewed changes
Copy link
Contributor

@BEAdi BEAdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Please ask for a doc-review.

Packs/CommonScripts/ReleaseNotes/1_19_15.md Outdated Show resolved Hide resolved
@ShirleyDenkberg ShirleyDenkberg self-assigned this Jan 27, 2025
@ShirleyDenkberg
Copy link
Contributor

@jbabazadeh @BEAdi Doc review completed.

@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • CommonScripts pack version was bumped to 1.19.16.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@YairGlick YairGlick merged commit e937ba2 into master Jan 28, 2025
17 checks passed
@YairGlick YairGlick deleted the ParseEmailFilesV2-script-add-description branch January 28, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShirleyDenkberg ShirleyDenkberg ShirleyDenkberg left review comments

@BEAdi BEAdi BEAdi approved these changes

@jbabazadeh jbabazadeh Awaiting requested review from jbabazadeh

Assignees

@ShirleyDenkberg ShirleyDenkberg

Labels
docs-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YairGlick @content-bot @ShirleyDenkberg @BEAdi