Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI defualt items per run fix and removed useless parse of ack function #38310

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@nicoloereni

  • fix default value items per run in UI
  • remove parse response for ack function because is not precise and useless

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

We found two minor issues:

  • one is related to the UI, qwe show the older default value for the "Item per run" form
  • the other refers to the response parsing of the ack function, it is not correct because the id is not always passed and in the end is useless because is not used by the prod code neither tests

Must have

  • Tests
  • Documentation

#38207)

* * ack parse was not correct and useless, so we removed it
* fix default value items per run in UI

* * make pre-commit check happy
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Partner Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved labels Jan 26, 2025
Copy link

github-actions bot commented Jan 26, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/NozomiNetworks/Integrations/NozomiNetworks
   NozomiNetworks.py2625678%66, 78–79, 87, 107, 184, 225, 233–235, 238, 242, 274, 280–281, 283, 297–300, 302, 304–305, 307–309, 311, 338–339, 345, 349, 358, 384, 451–458, 460–474
TOTAL2625678% 

Tests Skipped Failures Errors Time
71 0 💤 0 ❌ 0 🔥 2.336s ⏱️

@mayyagoldman mayyagoldman merged commit 02c2491 into master Jan 28, 2025
17 checks passed
@mayyagoldman mayyagoldman deleted the contrib/NozomiNetworks_nozomi_fix_minor_bug_ack_incident_for_vantage branch January 28, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants