Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crowd Strike Falcon - increase the default look-back #38347

Merged
merged 5 commits into from
Jan 28, 2025

Conversation

ShacharKidor
Copy link
Contributor

@ShacharKidor ShacharKidor commented Jan 27, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

It appears that the look-back mechanism is relative to the fetch interval size, therefore for setting a default look-back of 1 minute when the default fetch interval is 1 minute, we need to set the look-back to 2 minutes.

Must have

  • Tests
  • Documentation

@ShacharKidor ShacharKidor marked this pull request as ready for review January 27, 2025 12:51
Copy link

github-actions bot commented Jan 27, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon
   CrowdStrikeFalcon.py299374175%469, 494, 534, 546, 580–581, 583–584, 602, 793–795, 810, 813, 841–850, 871, 946, 984–985, 987, 990–992, 1040, 1070, 1129–1130, 1132, 1137, 1140–1141, 1156–1158, 1163, 1166–1167, 1182–1183, 1185, 1190, 1193–1194, 1222, 1224, 1229–1230, 1240, 1242, 1247–1248, 1358, 1479, 1481, 1509, 1511, 1533–1536, 1571, 1621, 1625, 1727, 1739–1740, 1742–1743, 1746, 1748, 1752–1753, 1789, 1798, 1803, 1832, 1834, 1862, 1866, 1898, 1900, 2030, 2036, 2047–2050, 2059–2063, 2113, 2116–2117, 2120, 2129, 2132–2133, 2136, 2152, 2184, 2190–2193, 2196, 2200, 2253–2254, 2256, 2260, 2263, 2266, 2270–2271, 2274, 2289, 2452–2456, 2461, 2464, 2467–2468, 2471–2473, 2475, 2484, 2486, 2566–2568, 2570–2572, 2689, 2694, 2698, 2702, 2742–2745, 2748, 2751, 2753–2754, 2797–2799, 2802–2804, 2806, 2827, 2934, 2961–2962, 2970, 2972, 3025–3026, 3035, 3037, 3078, 3156–3159, 3161, 3171–3174, 3176, 3218, 3221, 3228, 3230, 3409–3410, 3595, 3699–3700, 3702, 3740–3745, 3795–3798, 3867, 3874, 3912, 4001, 4039, 4057, 4071, 4085–4088, 4101–4105, 4107–4108, 4110–4111, 4123–4126, 4149, 4191, 4197, 4232–4240, 4242–4243, 4251–4264, 4266–4267, 4269, 4271–4272, 4274–4276, 4278–4281, 4283, 4285, 4287, 4299–4307, 4309–4322, 4330–4333, 4341–4344, 4380–4383, 4402–4407, 4409–4410, 4412–4419, 4429–4430, 4433, 4650–4652, 4659, 4681–4684, 4696, 4727–4730, 4746, 4778–4781, 4801–4802, 4812, 4825–4826, 4828, 4837–4840, 4881–4882, 4900–4903, 4948–4951, 4987, 4992–4993, 5035, 5037–5038, 5078–5079, 5085, 5106–5107, 5123–5124, 5139, 5153, 5156–5157, 5165, 5168–5169, 5180, 5184, 5223–5225, 5233–5235, 5237, 5264–5273, 5304, 5371–5374, 5377–5378, 5382–5385, 5388–5389, 5398–5399, 5401, 5403, 5405, 5407–5409, 5413, 5427–5431, 5496–5498, 5500, 5503, 5505, 5508, 5510–5512, 5514, 5516–5517, 5521–5525, 5530, 5532–5533, 5537–5538, 5540–5544, 5548, 5609, 5712, 6023, 6064, 6075, 6146, 6148, 6157, 6163, 6230, 6237, 6242, 6244, 6254, 6260, 6265, 6267–6268, 6270–6272, 6274, 6282, 6300, 6309, 6315, 6333, 6341, 6346, 6348–6349, 6351–6353, 6355, 6363, 6393, 6399, 6404, 6406, 6415, 6421, 6426, 6428–6429, 6431–6433, 6435, 6443, 6497, 6499–6500, 6502–6503, 6505, 6549–6550, 6552–6553, 6560, 6562, 6567, 6646, 6675–6676, 6684–6685, 6689, 6753, 6805, 6858, 6982, 7056–7057, 7059, 7061, 7078–7080, 7082–7087, 7089–7152, 7154–7165, 7172–7185, 7187–7188, 7190–7191, 7199–7200, 7202–7203, 7205–7206, 7208–7209, 7211–7215, 7219–7220, 7222–7224, 7228–7229, 7231–7236, 7238–7241, 7243–7292, 7294–7309, 7311, 7313–7314
TOTAL299374175% 

Tests Skipped Failures Errors Time
354 0 💤 0 ❌ 0 🔥 5.683s ⏱️

@ShacharKidor ShacharKidor merged commit d958fc1 into master Jan 28, 2025
17 checks passed
@ShacharKidor ShacharKidor deleted the CS-Falcon-increase-default-look-back branch January 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants