Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZeroFox] Replace min_timestamp filter with escalated_min_date when only escalated alerts are fetched as incidents #38377

Conversation

DNRRomero
Copy link
Contributor

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

Fix an issue identified when restricting the type of ZeroFox alerts ingested as XSOAR Incidents by correcting the filtering parameter in http request

Must have

  • Tests
  • Documentation

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jan 28, 2025
@content-bot content-bot changed the base branch from master to contrib/riskive_zerofox-fix_escalated_incidents_fetch January 28, 2025 19:08
@content-bot content-bot requested a review from talzich January 28, 2025 19:08
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @talzich will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @DNRRomero, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@talzich talzich merged commit 54ce209 into demisto:contrib/riskive_zerofox-fix_escalated_incidents_fetch Jan 30, 2025
17 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

talzich added a commit that referenced this pull request Jan 30, 2025
…nly escalated alerts are fetched as incidents (#38377) (#38414)

* Replace min_timestamp filter with escalated_min_date when escalated_only is enabled (#140)

* add release notes and upate yml structure

Co-authored-by: Diego Ramirez R <[email protected]>
Co-authored-by: Tal Zichlinsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants