Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: modify alert commands to work with new API #38389

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@hx0ar

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Description

Updates the 4 alert handling commands, so they work with the newer API related to "rules", since the old "alerts" system was deprecated quite some time ago.

Must have

  • Tests
  • Documentation

* fix: modify alert commands to work with new API

* chore: update release notes

* chore: run format

* chore: bump demisto docker version

* feat: alter columns in alerts list
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Partner Contribution Form Filled Whether contribution form filled or not. Partner Support Level Indicates that the contribution is for Partner supported pack Internal PR Partner-Approved labels Jan 29, 2025
@content-bot content-bot requested a review from talzich January 29, 2025 09:35
Copy link

github-actions bot commented Jan 29, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/SecurityScorecard/Integrations/SecurityScorecard
   SecurityScorecard.py44217560%48, 63, 71, 79, 86, 90, 98, 103, 111, 115, 123, 130–131, 133, 140, 146–147, 149, 157, 168, 173, 181, 189, 193, 201, 208, 216, 243, 261–265, 392, 394, 396–397, 399–401, 403–405, 436, 518, 757, 759, 764, 766, 768, 770, 775, 777, 779, 784, 786, 998, 1121, 1163–1164, 1166, 1168, 1174, 1190–1194, 1196, 1198, 1200–1201, 1210, 1212–1214, 1216–1219, 1222–1225, 1227, 1229, 1231, 1239, 1310, 1313, 1316, 1318–1319, 1323, 1325, 1328, 1331–1332, 1335–1338, 1340–1341, 1345–1346, 1349–1353, 1356–1357, 1359–1360, 1362, 1365–1368, 1370–1371, 1373–1375, 1378–1379, 1395, 1398–1399, 1402, 1405–1406, 1409–1410, 1412, 1414–1415, 1417, 1419, 1429–1460, 1463–1465
TOTAL44217560% 

Tests Skipped Failures Errors Time
51 0 💤 0 ❌ 0 🔥 2.402s ⏱️

@talzich talzich added the ForceMerge Forcing the merge of the PR despite the build status label Jan 29, 2025
@talzich
Copy link
Contributor

talzich commented Jan 29, 2025

Build failing because of breaking changes explained by the contributor in the external PR

@JudahSchwartz JudahSchwartz merged commit 3e436a0 into master Jan 29, 2025
17 of 20 checks passed
@JudahSchwartz JudahSchwartz deleted the contrib/hx0ar_fetch-alerts-improvements branch January 29, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved ForceMerge Forcing the merge of the PR despite the build status Internal PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants