Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unique userId instead of userName (display name) for ZoomAsk output entry #38451

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@ali-sawyer

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

https://xsoar.ideas.aha.io/ideas/FR-I-4373

Description

It is necessary to use a unique identifier rather than display name to uniquely identify the user who responded to the ZoomAsk question, because users can change their Zoom display names at will.

Must have

  • Tests
  • Documentation

…ut entry (#38129)

* change userName to userId

* update RNs

* fix where user ID vs name is used

* update unit test

* fix error in Zoom.py

Co-authored-by: Maya Goldman <[email protected]>

* increment RN number

* undo mistake on changing RN number

* remove extra newlines

* fix increment RN number

* add user email lookup

* add unit test for new function

* fix wrong import name in test

* added userId to mock_request.json.return_value

* patch zoom_get_user_email_by_id

* fixed expected page size in test

* pre commit

---------

Co-authored-by: Maya Goldman <[email protected]>
Co-authored-by: mayagoldman <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Feb 2, 2025
@mayyagoldman mayyagoldman merged commit 04b7718 into master Feb 3, 2025
41 checks passed
@mayyagoldman mayyagoldman deleted the contrib/ali-sawyer_zoom-userid branch February 3, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-contributor The PR is pending the response of its creator Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants