Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue when calling GitUtil directly and not via Content.git_util() #4665

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix issue when calling GitUtil directly and not via Content.git_util() #4665

wants to merge 1 commit into from

Conversation

kobymeir
Copy link
Contributor

Description

fix issue when calling GitUtil directly and not via Content.git_util()

@kobymeir kobymeir self-assigned this Nov 13, 2024
@kobymeir kobymeir marked this pull request as draft November 13, 2024 10:48
dorschw
dorschw reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@dorschw dorschw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to add a TID251 to Pyproject.toml, to require everyone to import from content?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw left review comments

@dantavori dantavori Awaiting requested review from dantavori dantavori is a code owner

@RosenbergYehuda RosenbergYehuda Awaiting requested review from RosenbergYehuda RosenbergYehuda is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kobymeir kobymeir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobymeir @dorschw