Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links; upgrade Dendron to fix Firefox experience #587

Merged
merged 7 commits into from
Jul 12, 2022

Conversation

ScriptAutomate
Copy link
Contributor

What does this PR do?

  • Upgrade dendron-cli used to publish site in order to be up-to-date, and to fix Firefox rendering problems
  • Fix url-check related errors in the pipeline due to outdated or broken links

What issues does this PR fix or reference?

NOTE: Fixes will close the ticket after merging. Relates to: will leave the ticket open after merging.

Merge requirements satisfied

For more information, visit the Contributing Guide for Documentation

  • Check rendered output to ensure formatting is correct for renderings of wikilinks, note refs, tables, and images. Dendron: Show Preview can be used in your workspace to confirm the page renders as expected. Sometimes, Dendron: Reload Index needs to be ran if certain wikilinks aren't working as expected. (ignore this if contribution is made via the Edit this page on GitHub button from the published site)
  • If this PR includes any refactoring (renaming notes, renaming headers, etc.), make sure that these changes were done via Dendron Refactoring Commands. This will ensure that any other impacted areas of the documentation, that link to or embed modified notes (via note references), are automatically updated.

Verify GitHub Actions tests are passing, which can be seen in the Checks tab of the PR:

  • URL validator GitHub Action passes
  • Dendron site build GitHub Action passes

NOTE: If you are a new contributor, a maintainer will need to provide approval for GitHub Actions to run on your PRs.

@ScriptAutomate ScriptAutomate changed the title Fix broken links; upgrade Dendron to fix Firefox Fix broken links; upgrade Dendron to fix Firefox experience Jul 12, 2022
@kevinslin kevinslin merged commit 39b764f into dendronhq:dev Jul 12, 2022
@ScriptAutomate ScriptAutomate deleted the fix-firefox-and-broken-links branch July 12, 2022 01:52
@jonathanyeung
Copy link
Contributor

Thanks @ScriptAutomate!

@ultrablue
Copy link

It looks fixed to me.
Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants