Use std::string_view in data_connection methods

deniskovalchuk · Aug 7, 2023 · f936450 · f936450
1 parent e5fb862
commit f936450
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/ftp/include/ftp/detail/data_connection.hpp b/src/ftp/include/ftp/detail/data_connection.hpp
@@ -30,6 +30,7 @@
 #include "../transfer_callback.hpp"
 #include <boost/asio/ip/tcp.hpp>
 #include <memory>
+#include <string_view>
 
 namespace ftp::detail
 {
@@ -43,9 +44,9 @@ class data_connection
 
     data_connection & operator=(const data_connection &) = delete;
 
-    void open(const std::string & ip, std::uint16_t port);
+    void open(std::string_view ip, std::uint16_t port);
 
-    void listen(const std::string & ip, std::uint16_t port);
+    void listen(std::string_view ip, std::uint16_t port);
 
     void accept();
 

diff --git a/src/ftp/src/data_connection.cpp b/src/ftp/src/data_connection.cpp
@@ -38,7 +38,7 @@ data_connection::data_connection()
 {
 }
 
-void data_connection::open(const std::string & ip, std::uint16_t port)
+void data_connection::open(std::string_view ip, std::uint16_t port)
 {
     boost::system::error_code ec;
 
@@ -67,7 +67,7 @@ void data_connection::open(const std::string & ip, std::uint16_t port)
     }
 }
 
-void data_connection::listen(const std::string & ip, std::uint16_t port)
+void data_connection::listen(std::string_view ip, std::uint16_t port)
 {
     boost::system::error_code ec;