Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remotes:
Actions:
git fetch upstream
git checkout upstream/release-5.7
and ensured it was on the commit of the release.git checkout -b branch_v5.7.3
git push denoland
git checkout -b branch_v5.7.3_patch
denoland/branch_5.6.5_patch
intodenoland/branch_v5.7.3_patch
and squashed the commitsnpm install && npx hereby services dts-services
(to build)globals
orglobalThisSymbol
not existing, it's because they're calleddenoGlobals
/nodeGlobals
anddenoGlobalThisSymbol
/nodeGlobalThisSymbol
in this forkglobals
orglobalThisSymbol
in checker.ts, update that code to be properly handled using eitherdenoGlobals
/nodeGlobals
ordenoGlobalThisSymbol
/nodeGlobalThisSymbol
(note:globalThisType
refers to the globalthis
type and not the globalglobalThis
type)cp built/local/typescript.js ../deno/cli/tsc/00_typescript.js
built/local
to../deno/cli/tsc/dts
then deleted files that didn't seem necessary (ex. typescript.internal.d.ts).ScriptElementKind
in the ts codebase has changed and if so, align withScriptElementKind
in cli/lsp/tsc.rscargo test check
andcargo test lsp
https://github.com/denoland/deno/tree/main/cli/tsc#how-to-upgrade-typescript