Skip to content

Commit

Permalink
chore: make Node setup script less sensitive to changes (#22855)
Browse files Browse the repository at this point in the history
This change tweaks the Node setup script less sensitive to changes by
removing the test counter line in `tools/node_compat/TODO.md`.
Previously, this line would cause linting issues when two Node compat
changes occured one after another.

See
https://github.com/denoland/deno/actions/runs/8226735149/job/22493585874

Signed-off-by: Asher Gomez <[email protected]>
  • Loading branch information
iuioiua authored Mar 12, 2024
1 parent 61d86b9 commit c38c14f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 4 deletions.
2 changes: 0 additions & 2 deletions tools/node_compat/TODO.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@

NOTE: This file should not be manually edited. Please edit `tests/node_compat/config.json` and run `deno task setup` in `tools/node_compat` dir instead.

Total: 2996

- [abort/test-abort-backtrace.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-backtrace.js)
- [abort/test-abort-fatal-error.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-fatal-error.js)
- [abort/test-abort-uncaught-exception.js](https://github.com/nodejs/node/tree/v18.12.1/test/abort/test-abort-uncaught-exception.js)
Expand Down
2 changes: 0 additions & 2 deletions tools/node_compat/setup.ts
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,6 @@ async function updateToDo() {
NOTE: This file should not be manually edited. Please edit \`tests/node_compat/config.json\` and run \`deno task setup\` in \`tools/node_compat\` dir instead.
Total: ${missingTests.length}
`));
for (const test of missingTests) {
await file.write(
Expand Down

0 comments on commit c38c14f

Please sign in to comment.