Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a message if a newer version is available #14133

Closed
nobsaibot opened this issue Mar 27, 2022 · 2 comments
Closed

Show a message if a newer version is available #14133

nobsaibot opened this issue Mar 27, 2022 · 2 comments
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)

Comments

@nobsaibot
Copy link

Hi everyone!
And thank you for this awesome project!

I found this feature in the GitHub CLI application and npm.

I think it'll be useful for users who install deno using the installation script.
And this will let them know that a new version is available and it's time to update.

Ready-made crates to do that:

@kitsonk kitsonk added the suggestion suggestions for new features (yet to be agreed) label Mar 27, 2022
@lucacasonato lucacasonato added the cli related to cli/ dir label Mar 29, 2022
@ducaale
Copy link

ducaale commented Sep 7, 2022

In case it helps, a similar discussion happened in ducaale/xh#249

  • Considering security/performance implications, I'm not a fan of tools that auto-check for updates without the user's consent.
  • However, a good compromise might be to only check for updates when deno --version is used (refer to terraform version for prior art).
  • The notifier should probably be disabled if deno is installed using a package manager.

@lino-levan
Copy link
Contributor

This was added when #15974 was merged. Should this issue be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli related to cli/ dir suggestion suggestions for new features (yet to be agreed)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants