Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): check for updates #15777

Closed
wants to merge 1 commit into from
Closed

feat(cli): check for updates #15777

wants to merge 1 commit into from

Conversation

mgrachev
Copy link

@mgrachev mgrachev commented Sep 5, 2022

Close #14133

@CLAassistant
Copy link

CLAassistant commented Sep 5, 2022

CLA assistant check
All committers have signed the CLA.

Signed-off-by: Mikhail Grachev <[email protected]>
@@ -105,6 +105,7 @@ tokio-util = "=0.7.2"
tower-lsp = "=0.17.0"
twox-hash = "=1.6.2"
typed-arena = "2.0.1"
update-informer = { version = "0.5.0", default_features = false, features = ["github"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing this is pretty trivial so I'd rather we not use a dependency for this. We also want to check stuff like canary builds.

There is also another open PR #15543.

@bartlomieju
Copy link
Member

@mgrachev thank you for the PR, but this implementation is not what we had in mind. The problem with it is that it is blocking and incurs a huge startup time. I'm going to respectfully close it in favor of #15974.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show a message if a newer version is available
4 participants