fix(lsp): improved npm specifier to import map entry mapping #22016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Jan 21, 2024
| matches | ||
| .push(format!("{}{}", entry.raw_key, key_sub_path)); | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This code now goes from import map entry to npm package req and from that figures out a match instead of going from pkg req -> specifier, then calling import_map.lookup on the possible specifiers. We can no longer rely on a mapping from PkgReq -> specifier because we normalize and eliminate duplicate PackageReqs based on their RangeSetAndTag since denoland/deno_semver@98f9174
dsherret
commented
Jan 21, 2024
| } else if let Some(file_stem) = file_name.strip_suffix(".d.mts") { | ||
| search_paths | ||
| .push(specifier_path.with_file_name(format!("{}.mjs", file_stem))); | ||
| } |
There was a problem hiding this comment.
Found this situation while writing the test.
dsherret
commented
Jan 21, 2024
| @@ -1342,7 +1342,7 @@ dependencies = [ | |||
| "import_map", | |||
| "indexmap", | |||
| "log", | |||
| "monch", | |||
| "monch 0.4.3", | |||
There was a problem hiding this comment.
This duplicate monch dep will be fixed in denoland/deno_graph#361
bartlomieju
pushed a commit
to bartlomieju/deno
that referenced
this pull request
Jan 22, 2024
…d#22016) Upgrades to the latest deno_semver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted out from #22004
Upgrades to the latest deno_semver