feat(ext/geometry): Geometry Interfaces Module Level 1 #22054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petamoriken
force-pushed
the
feat/geometry
branch
3 times, most recently
from
3343fa4 to
4206e6c
Compare
petamoriken
force-pushed
the
feat/geometry
branch
3 times, most recently
from
b53a1a1 to
7d33171
Compare
bartlomieju
reviewed
Mar 27, 2024
tests/integration/lsp_tests.rs
Outdated
| @@ -5076,7 +5076,7 @@ fn lsp_jsr_auto_import_completion() { | |||
| json!({ "triggerKind": 1 }), | |||
| ); | |||
| assert!(!list.is_incomplete); | |||
| assert_eq!(list.items.len(), 261); | |||
| assert_eq!(list.items.len(), 268); | |||
There was a problem hiding this comment.
Yikes, this is a bit concerning that adding new globals requires changes in seemingly unrelated tests for the LSP. I've opened #23102 to tackle that.
bartlomieju
reviewed
Mar 27, 2024
bartlomieju
reviewed
Mar 28, 2024
Comment on lines
+4
to
+6
| name = "deno_geometry" | ||
| version = "0.1.0" | ||
| authors.workspace = true |
There was a problem hiding this comment.
Note to self: I already claimed https://crates.io/crates/deno_geometry to avoid problems during publishing when this PR lands
|
@petamoriken I spoke with @littledivy earlier today and he's close to landing all necessary changes to |
|
Blocked by denoland/deno_core#682 |
|
Superseded by #27527 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #21608