feat: add preventCloseOnEOF option #24247
Open
+337
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
preventCloseOnEOF
option toDeno.open
,Deno.create
,Deno.connect
,Deno.connectTls
, andDeno.startTls
. It ensures that readablestreams returned from the objects'
readable
properties do not automaticallyclose the underlying resource when EOF is reached.
This option is described here: #22258 (comment)
Additionally it adds a bunch of docs for
readable
andwritable
, alsooutlining some common footguns.
As a drive by fix, one can now also pass
mode
toDeno.create
, like youalready can for
Deno.open
.Fixes #22258
Fixes #15442 (by adding docs)
And helps with #17828