fix: prevent setting unstable feature twice #24381
Merged
+39
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix. Could you add a "spec" tests with this scenario (#22015 (comment)) to |
bartlomieju
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent panic when enabling a feature that is already enabled by removing duplicate features.
This commit addresses issue #22015
Problem source
fn unstable_feature()ofCliOptionsfetches the unstable flags from both the subcommand to execute and the config file deno.json without checking for repetition among the flags found.Solution & Code change
Make sure to set/add no more than one of each of the flags mentioned within config file and the subcommand without repetition of any flag by updating
fn unstable_features().Closes #22015