feat(serve): env var DENO_SERVE_ADDRESS for configuring default listener address
#24382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
changed the title
DENO_SERVE_ADDRESS for configuring default lis…DENO_SERVE_ADDRESS for configuring default listener address
bartlomieju
requested changes
Jul 1, 2024
Comment on lines
+598
to
+602
| const canOverrideOptions = !ObjectHasOwn(options, "path") | ||
| && !ObjectHasOwn(options, "hostname") | ||
| && !ObjectHasOwn(options, "port"); | ||
| const env = Deno.permissions.querySync({ name: "env", variable: "DENO_SERVE_ADDRESS" }).state === "granted" | ||
| && Deno.env.get("DENO_SERVE_ADDRESS"); |
There was a problem hiding this comment.
This looks very funky. We are already forwarding host and port in
deno/runtime/worker_bootstrap.rs
Lines 94 to 96 in cd4a007
deno serve subcommand. Otherwise this code will be applied to every single Deno.serve() call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for configuring a default listen address for
Deno.serve()with theDENO_SERVE_ADDRESSenvironment variable. If none ofoptions.{hostname,port,path}is set, the listener will attempt to parseDENO_SERVE_ADDRESSand listen on the specified endpoint.The listen address is specified in a
network/addressformat. For example:tcp/0.0.0.0:8080unix//var/run/http.sock