Loader improvements #2453
Merged
Loader improvements #2453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch makes it so that RecursiveLoad doesn't own the Isolate, so Worker::execute_mod_async does not consume itself. Previously Worker implemented Loader, but now ThreadSafeState does. This is necessary preparation work for dynamic import (denoland#1789) and import maps (denoland#1921)
piscisaureus
reviewed
Jun 5, 2019
| let referrer = referrer.to_string(); | ||
|
|
||
| let f = | ||
| futures::future::result(ThreadSafeState::resolve(&specifier, &referrer)); |
There was a problem hiding this comment.
This is ok, but here's a tip: Result has an IntoFuture impl so you can do ThreadSafeState::resolve(&specifier, &referrer).into_future().and_then(...).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it so that RecursiveLoad doesn't own the Isolate, so
Worker::execute_mod_asyncdoes not take ownership anymore.Previously Worker implemented Loader, but now ThreadSafeState does.
This is necessary preparation work for dynamic import (#1789) and import maps (#1921)