Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve lockfile v4 to store normalized version constraints and be more terse #25247

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Aug 28, 2024

Stores normalized version constraints in the lockfile, which will improve reproducibility and will fix a bug with duplicate specifiers ending up in the lockfile. Also, gets rid of some duplicate data in the specifiers area of the lockfile.

@dsherret dsherret added the ci-draft Run the CI on draft PRs. label Aug 28, 2024
@dsherret

This comment was marked as outdated.

@dsherret dsherret changed the title feat: improve lockfile v4 to store normalized version constraints feat: improve lockfile v4 to store normalized version constraints and be more terse Aug 28, 2024
@dsherret dsherret removed the ci-draft Run the CI on draft PRs. label Aug 28, 2024
@dsherret dsherret marked this pull request as ready for review August 28, 2024 15:28
@dsherret dsherret requested a review from bartlomieju August 28, 2024 15:31
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

@dsherret dsherret merged commit b708a13 into denoland:main Aug 28, 2024
17 checks passed
@dsherret dsherret deleted the improve_lockfile_v4 branch August 28, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants