Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Mark microtask ops fast" #953

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Revert "Mark microtask ops fast" #953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions core/ops_builtin_v8.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ pub fn op_lazy_load_esm(
module_map_rc.lazy_load_esm_module(scope, &module_specifier)
}

#[op2(fast)]
// We run in a `nofast` op here so we don't get put into a `DisallowJavascriptExecutionScope` and we're
// allowed to touch JS heap.
#[op2(nofast)]
pub fn op_queue_microtask(
isolate: *mut v8::Isolate,
cb: v8::Local<v8::Function>,
Expand All @@ -210,7 +212,9 @@ pub fn op_queue_microtask(
}
}

#[op2(fast, reentrant)]
// We run in a `nofast` op here so we don't get put into a `DisallowJavascriptExecutionScope` and we're
// allowed to touch JS heap.
#[op2(nofast, reentrant)]
pub fn op_run_microtasks(isolate: *mut v8::Isolate) {
// SAFETY: we know v8 provides us with a valid, non-null isolate
unsafe {
Expand Down
Loading