Skip to content

Commit

Permalink
Simplify bin example in README (#356)
Browse files Browse the repository at this point in the history
Co-authored-by: Yoshiya Hinosawa <[email protected]>
  • Loading branch information
felipecrs and kt3k authored Apr 22, 2024
1 parent d4b033f commit 4d61d7d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .bmp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ commit: '%.%.%'
files:
README.md:
- 'denoland/deno:%.%.%'
- ARG DENO_VERSION=%.%.%
- 'denoland/deno:bin-%.%.%'
alpine.dockerfile: ARG DENO_VERSION=%.%.%
bin.dockerfile: ARG DENO_VERSION=%.%.%
centos.dockerfile: ARG DENO_VERSION=%.%.%
Expand Down
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,18 @@ If you prefer to install `deno` in your own base image, you can use the
`denoland/deno:bin` to simplify the process.

```Dockerfile
ARG DENO_VERSION=1.42.4

FROM denoland/deno:bin-$DENO_VERSION AS deno
FROM ubuntu
COPY --from=deno /deno /usr/local/bin/deno
COPY --from=denoland/deno:bin-1.42.4 /deno /usr/local/bin/deno
```

## Running on Google Cloud Run(GCR)
Due to conflicts with google cloud run caching mechanism it's required to use different path for `DENO_DIR` in your Dockerfile.
```

```Dockerfile
# set DENO_DIR to avoid conflicts with google cloud
ENV DENO_DIR=./.deno_cache
```

Without it GCR instance will try to download deps every time. When running with `--cached-only` you will get `Specified not found in cache`.

## (optional) Add `deno` alias to your shell
Expand Down

0 comments on commit 4d61d7d

Please sign in to comment.