Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cache bust on http checksum failure #567

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 6, 2025

This attempts to cache bust the remote specifier on checksum failure. This is useful in the following scenario:

  1. User downloads a remote module from esm.sh to their local cache
  2. esm.sh changes their code
  3. Another dev updates the lockfile in the repo
  4. User pulls in the new lockfile and attempts running their code, only to get an error (with this change, it now pulls it in)

@dsherret dsherret requested a review from bartlomieju February 6, 2025 21:16
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dsherret dsherret merged commit 72f0944 into denoland:main Feb 6, 2025
16 checks passed
@dsherret dsherret deleted the fix_cache_bust_on_lockfile_failure branch February 6, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants