Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add flags to skip prompts and avoid modifying PATH #303

Merged
merged 8 commits into from
Oct 1, 2024

Conversation

nathanwhit
Copy link
Member

@nathanwhit nathanwhit commented Sep 30, 2024

Closes #297. Closes denoland/deno#25931

Adds a flag to skip prompts and accept defaults, and a flag to disable modifying the PATH. This is essentially the same as what rustup has for its installer.

Options:
  -y, --yes
    Skip interactive prompts and accept defaults
  --no-modify-path
    Don't add deno to the PATH environment variable
  -h, --help
    Print help

Also adds a couple of integration tests for the installer, simulating a PTY to check how it would behave in an actual terminal.


The diff looks big, but the core of it is in install.sh and main.ts. The test file is mostly helper/boilerplate for the initial tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, nice work 👍

@nathanwhit nathanwhit merged commit 26c905a into denoland:master Oct 1, 2024
4 checks passed
@nathanwhit nathanwhit deleted the flags branch October 1, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants