Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: use and create OAuth2ClientConfig instead of OAuth2Client #207

Merged
merged 15 commits into from
Sep 20, 2023

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Sep 19, 2023

Some cleanups and improvements will need to come after this.

Closes #196 via the new getRequiredEnv()
Closes #174
Partially addressed #193 by making scope flatter for pre-defined configurations
Supercedes #186

CC @jollytoad

@iuioiua iuioiua changed the title refactor!: use and create OAuth2ClientConfig instead of OAuth2Client BREAKING: use and create OAuth2ClientConfig instead of OAuth2Client Sep 20, 2023
@iuioiua iuioiua requested a review from kt3k September 20, 2023 01:28
@iuioiua iuioiua marked this pull request as ready for review September 20, 2023 01:42
@iuioiua iuioiua enabled auto-merge (squash) September 20, 2023 04:46
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice!

@iuioiua iuioiua merged commit f88917a into main Sep 20, 2023
@iuioiua iuioiua deleted the oauth-config branch September 20, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Common configuration function with validation Suggestion: Providers return config only
2 participants