feat: add curly lint rule
#1383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
reviewed
Jan 2, 2025
bartlomieju
approved these changes
Jan 2, 2025
dsherret
requested changes
Jan 2, 2025
There was a problem hiding this comment.
Going to block the merge of this one. I'm not sure this should be a lint rule because it's something that can be enforced via code formatting. It also conflicts with what deno fmt currently does: https://dprint.dev/playground/#code/JYMwFALgTgrgpgSgAQG8kGMD2A7AzpgGzgDoDMBzMAVgQG4kBfIA/config/N4KABGBEAmCmB2B7SAuMAXATgV1iAvkA/plugin/typescript
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a lint rule for consistent curly braces around control statements. It's similar to eslint's https://eslint.org/docs/latest/rules/curly rule.
Fixes denoland/deno#27493
Docs: denoland/docs#1302