fix: remoteAddr hardcoded to localhost:1234 (#1839)

denoland · Oct 2, 2023 · 0a0d86e · 0a0d86e
1 parent 4295dbe
commit 0a0d86e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/server/boot.ts b/src/server/boot.ts
@@ -60,7 +60,18 @@ async function bootServer(handler: ServeHandler, opts: StartOptions) {
   // @ts-ignore Ignore type error when type checking with Deno versions
   if (typeof Deno.serve === "function") {
     // @ts-ignore Ignore type error when type checking with Deno versions
-    await Deno.serve(opts, handler).finished;
+    await Deno.serve(
+      opts,
+      (r, { remoteAddr }) =>
+        handler(r, {
+          remoteAddr,
+          localAddr: {
+            transport: "tcp",
+            hostname: opts.hostname ?? "localhost",
+            port: opts.port,
+          } as Deno.NetAddr,
+        }),
+    ).finished;
   } else {
     // @ts-ignore Deprecated std serve way
     await serve(handler, opts);

diff --git a/tests/server_components_test.ts b/tests/server_components_test.ts
@@ -82,7 +82,7 @@ Deno.test({
               transport: "tcp",
             },
             remoteAddr: {
-              hostname: "localhost",
+              hostname: "127.0.0.1",
               port: 8000,
               transport: "tcp",
             },