Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure file paths in snapshot.json uses / #2704

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: ensure file paths in snapshot.json uses / #2704

merged 1 commit into from
Oct 15, 2024

Conversation

csvn
Copy link
Contributor

@csvn csvn commented Oct 11, 2024

Avoids \\\\ paths ending up in snapshot.json when using deno task build on Windows. Backslashes do not which pathnames in URLs, so these assets are not returned.

Closes #2703

@csvn
Copy link
Contributor Author

csvn commented Oct 11, 2024

I think perhaps the .addProcessedFile() will produce the same error, but I only fixed this for the "Un"-processed files.

marvinhagemeister
marvinhagemeister approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, great catch! Love that you added a test as well!

@marvinhagemeister marvinhagemeister merged commit 628832a into denoland:main Oct 15, 2024
7 checks passed
@csvn csvn deleted the fix/fresh-build-windows branch October 15, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fresh-v2] Building assets with subfolders fails on windows
2 participants
@csvn @marvinhagemeister