www: docs: fix: Header nav items shouldn't wrap on mobile #2821
+54
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
www/components/Header.tsx
Outdated
Comment on lines
27
to
35
| <div class="flex justify-end"> | ||
| <NavigationBar class="" active={props.active} /> | ||
| <div class="flex [&_.github]:hidden [&_.github]:sm:flex [&_ul]:space-x-2 [&_ul]:sm:space-x-4 [&_li:hover]:text-green-600"> | ||
| <SocialIcons /> | ||
| </div> | ||
| <div class="flex px-3 sm:px-6 fill-foreground-primary hover:fill-fresh [&_*]:transition "> | ||
| {isDocs && <ThemeToggle />} | ||
| </div> | ||
| </div> |
There was a problem hiding this comment.
Something is off with the spacing
There was a problem hiding this comment.
I think this should fix that: 85016ef
There was a problem hiding this comment.
Sorry I should have left a screenshot:
…ipt tag's src attribute" This reverts commit d51f07a.
…01/mobile_move_social_icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up on #2820
I noticed the addition of the extra icon in the nav bar made the nav items in the Header newline wrap on small screens (mobile smaller than sm).
This pull request fixes that by doing the following:
Some other changes I snuck in: