feat: cppgc NameProvider #1528
Merged
feat: cppgc NameProvider #1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devsnek
force-pushed
the
name-trait
branch
4 times, most recently
from
a1022c1 to
3ebec4c
Compare
ry
reviewed
Sep 5, 2024
tests/test_cppgc.rs
Outdated
| @@ -44,6 +44,10 @@ fn cppgc_object_wrap() { | |||
| TRACE_COUNT.fetch_add(1, Ordering::SeqCst); | |||
| visitor.trace(&self.value); | |||
| } | |||
|
|
|||
| fn get_name(&self) -> Option<&'static std::ffi::CStr> { | |||
| Some(c"Wrap") | |||
There was a problem hiding this comment.
test somewhere that you can see this value?
There was a problem hiding this comment.
afaik there isn't really an easy way to test this since heap dumps need to be loaded into chrome to be read.
There was a problem hiding this comment.
maybe just see if it contains the byte string Wrap ? (maybe use a different magic string)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements NameProvider, but I didn't want RustObj to grow beyond 2 pointers, so replace it with a dyn pointer and use that to dispatch.