Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Google Analytics plugin #580

Closed
wants to merge 1 commit into from

Conversation

revgum
Copy link
Contributor

@revgum revgum commented Sep 12, 2023

Before writing the README updates, I wanted to get this PR out for 👁️ and 🧠 @iuioiua .. I lifted this from the Fresh site and translated it into a plugin here. I've tested it locally, and it's working great with localhost.

This might serve as a good starting point for #72

Screenshot 2023-09-12 at 5 46 56 AM Screenshot 2023-09-12 at 5 47 05 AM

@revgum revgum changed the title adds ga4 plugin leveraged from how the fresh site does it feature: add Google Analytics plugin Sep 12, 2023
@iuioiua
Copy link
Contributor

iuioiua commented Sep 14, 2023

This looks cool! Let's look at merging this after v1. In the meantime, we can improve on test coverage and whatever else 👍🏾

@iuioiua
Copy link
Contributor

iuioiua commented Nov 2, 2023

Hi @revgum, we're pushing the launch of v1 out till early next year now. And we'd be happy to accept more features before then. Is this PR something you still like to pursue for before v1 is launched? If so, please let me know once ready for review.

@deer
Copy link
Contributor

deer commented Dec 6, 2023

@iuioiua, as an alternative, there's something I created: https://deno.land/x/[email protected]
Although you probably want me to add some test coverage to my repo as well!

If you want I could create a PR that integrates the existing plugin into saaskit.

@iuioiua
Copy link
Contributor

iuioiua commented Dec 6, 2023

Hi @deer, that looks great! I'd gladly look at a PR that makes use of that plugin. I think this PR has gone stale. And yes, it would be great if there were some tests added, but it might do for now 🙂

@ooker777
Copy link

UA has officially stopped working. It's time to take this article down or at least have an update to point to working plugins
https://deno.com/blog/ga-with-deno-deploy

@iuioiua
Copy link
Contributor

iuioiua commented Jan 15, 2024

UA has officially stopped working. It's time to take this article down or at least have an update to point to working plugins https://deno.com/blog/ga-with-deno-deploy

That article is unrelated to this PR (which uses GA4) and this repo.

@iuioiua
Copy link
Contributor

iuioiua commented Jan 15, 2024

Closing in favour of #654. Either way, thank you, @revgum.

@iuioiua iuioiua closed this Jan 15, 2024
@ooker777
Copy link

ooker777 commented Jan 16, 2024

oh I didn't know that Deno Saaskit, Deno Blog and Deno Deploy are separate projects. By saying "point to working plugins" I was thinking about the 2 plugins in here. I don't know which repo I should raise the issue, so I do it in Discord

@iuioiua
Copy link
Contributor

iuioiua commented Jan 17, 2024

Ah, I see you created denoland/docs#277. Yep, that's the right way to fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants