Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(assert,fmt,fs,internal,path): skip yanked versions manually #4683

Merged
merged 3 commits into from
May 7, 2024

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented May 7, 2024

I updated the tool for upgrading the versions of packages (ref), and now the tool always respect the versions which are manually modified (This change was made for supporting manual upgrade of std/bytes from 0.224.0 to 1.0.0-rc.1). Because of this tool update, we need to skip these yanked versions manually.

This unblocks the next release of std packages.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (cd4f516) to head (f71fe0a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4683   +/-   ##
=======================================
  Coverage   91.47%   91.47%           
=======================================
  Files         477      477           
  Lines       37318    37318           
  Branches     5325     5325           
=======================================
  Hits        34137    34137           
  Misses       3125     3125           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k merged commit 4c769f8 into denoland:main May 7, 2024
12 checks passed
@kt3k kt3k deleted the skip-yanked-versions-2 branch May 7, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants