New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deref garbage collected owned refs #41

Merged

eliassjogreen merged 1 commit into main from fix/deref-garbage-refs

Jul 22, 2023

Member

eliassjogreen commented Jul 21, 2023

I think we need to be careful with borrowed refs in addition to remembering to decrefing all rc'd refs.

NOTE: This should be tested to make sure we don't have any memory leaks or use-after-free issues.
This should be fine though and was tested with --v8-flags=--allow-natives-syntax and the natives function %CollectGarbage(true)


          fix: deref garbage collected owned refs

dd1c736

eliassjogreen requested a review from DjDeveloperr

July 21, 2023 12:52

eliassjogreen merged commit 8988fe4 into main

4 checks passed

eliassjogreen deleted the fix/deref-garbage-refs branch

July 22, 2023 21:17

eliassjogreen mentioned this pull request

Leaking semaphore #38

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet