Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pyMethodDef layout #65

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix pyMethodDef layout #65

merged 2 commits into from
Jul 15, 2024

Conversation

sigmaSd
Copy link
Contributor

@sigmaSd sigmaSd commented Jul 14, 2024

fix #64
from AapoAlas

Yeah, the last pointer is not correctly aligned. Pointers should be 8 byte aligned (regardless of architecture), but it's at byte index 20: 20/8 does not an integer make.
So 24 is the correct place for it

@sigmaSd sigmaSd mentioned this pull request Jul 14, 2024
Closed
DjDeveloperr
DjDeveloperr approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@DjDeveloperr DjDeveloperr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

CI seems to be broken due to something else, I'll look into that later.

@DjDeveloperr DjDeveloperr merged commit 43e4957 into denosaurs:main Jul 15, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DjDeveloperr DjDeveloperr DjDeveloperr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfault when overriding a class method in jupyter kernel
2 participants
@sigmaSd @DjDeveloperr